Hi Nicolas, I'm done with v4 review.
Please post a v6, I don't plan to review v5 that was posted while I was in the middle of my review. Thanks, Maxime On 9/22/22 02:27, Nic Chautru wrote:
v4: Rebase to split the first commit and change the order within the series based on Maxime's feedback. No functional change. v3: Merge ACC100 and ACC200 PMDs in the same directory v2: Includes now code refactory to have common structures and code reused with the parallel ACC1XX serie PMD which can be shared moving forward. v1: This is targeting 22.11 and includes the PMD for the new integrated accelerator on Intel Xeon SPR-EEC. There is a dependency on that parallel patch serie still in-flight which extends the bbdev api https://patches.dpdk.org/project/dpdk/list/?series=23894 and is required to apply that patch. Nic Chautru (14): baseband/acc100: remove unused registers baseband/acc100: refactor to segregate common code baseband/acc: rename directory from acc100 to acc baseband/acc: introduce PMD for ACC200 baseband/acc: add HW register definitions for ACC200 baseband/acc: add info get function for ACC200 baseband/acc: add queue configuration for ACC200 baseband/acc: add LDPC processing functions baseband/acc: add LTE processing functions baseband/acc: add support for FFT operations baseband/acc: support interrupt baseband/acc: add device status and vf2pf comms baseband/acc: add PF configure companion function baseband/acc: simplify meson dependency MAINTAINERS | 5 +- app/test-bbdev/meson.build | 4 +- app/test-bbdev/test_bbdev_perf.c | 81 +- doc/guides/bbdevs/acc200.rst | 244 ++ doc/guides/bbdevs/index.rst | 1 + drivers/baseband/acc/acc100_pf_enum.h | 147 + drivers/baseband/acc/acc100_pmd.h | 177 + drivers/baseband/acc/acc100_vf_enum.h | 73 + drivers/baseband/acc/acc101_pmd.h | 40 + drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 196 ++ drivers/baseband/acc/acc200_vf_enum.h | 83 + drivers/baseband/acc/acc_common.h | 1387 ++++++++ drivers/baseband/acc/meson.build | 8 + drivers/baseband/acc/rte_acc100_cfg.h | 49 + drivers/baseband/acc/rte_acc100_pmd.c | 4655 +++++++++++++++++++++++++ drivers/baseband/acc/rte_acc200_cfg.h | 48 + drivers/baseband/acc/rte_acc200_pmd.c | 4195 +++++++++++++++++++++++ drivers/baseband/acc/rte_acc_common_cfg.h | 101 + drivers/baseband/acc/version.map | 10 + drivers/baseband/acc100/acc100_pf_enum.h | 1086 ------ drivers/baseband/acc100/acc100_pmd.h | 624 ---- drivers/baseband/acc100/acc100_vf_enum.h | 73 - drivers/baseband/acc100/acc101_pmd.h | 50 - drivers/baseband/acc100/meson.build | 8 - drivers/baseband/acc100/rte_acc100_cfg.h | 113 - drivers/baseband/acc100/rte_acc100_pmd.c | 5288 ----------------------------- drivers/baseband/acc100/version.map | 9 - drivers/baseband/meson.build | 2 +- 29 files changed, 11605 insertions(+), 7260 deletions(-) create mode 100644 doc/guides/bbdevs/acc200.rst create mode 100644 drivers/baseband/acc/acc100_pf_enum.h create mode 100644 drivers/baseband/acc/acc100_pmd.h create mode 100644 drivers/baseband/acc/acc100_vf_enum.h create mode 100644 drivers/baseband/acc/acc101_pmd.h create mode 100644 drivers/baseband/acc/acc200_pf_enum.h create mode 100644 drivers/baseband/acc/acc200_pmd.h create mode 100644 drivers/baseband/acc/acc200_vf_enum.h create mode 100644 drivers/baseband/acc/acc_common.h create mode 100644 drivers/baseband/acc/meson.build create mode 100644 drivers/baseband/acc/rte_acc100_cfg.h create mode 100644 drivers/baseband/acc/rte_acc100_pmd.c create mode 100644 drivers/baseband/acc/rte_acc200_cfg.h create mode 100644 drivers/baseband/acc/rte_acc200_pmd.c create mode 100644 drivers/baseband/acc/rte_acc_common_cfg.h create mode 100644 drivers/baseband/acc/version.map delete mode 100644 drivers/baseband/acc100/acc100_pf_enum.h delete mode 100644 drivers/baseband/acc100/acc100_pmd.h delete mode 100644 drivers/baseband/acc100/acc100_vf_enum.h delete mode 100644 drivers/baseband/acc100/acc101_pmd.h delete mode 100644 drivers/baseband/acc100/meson.build delete mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h delete mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c delete mode 100644 drivers/baseband/acc100/version.map
