> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Saturday, September 24, 2022 02:58
> To: Guo, Junfeng <junfeng....@intel.com>
> Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>; ferruh.yi...@xilinx.com; dev@dpdk.org; Li,
> Xiaoyun <xiaoyun...@intel.com>; awogbem...@google.com; Richardson,
> Bruce <bruce.richard...@intel.com>; Lin, Xueqin <xueqin....@intel.com>;
> Wang, Haiyue <haiyue.w...@intel.com>
> Subject: Re: [PATCH v3 1/9] net/gve: introduce GVE PMD base code
>
> On Fri, 23 Sep 2022 17:38:21 +0800
> Junfeng Guo <junfeng....@intel.com> wrote:
>
> > +#define GVE_DEVICE_OPTION_TOO_BIG_FMT "Length of %s option
> larger than expected. Possible older version of guest driver."
>
> Why do you need #define for this?
This macro is used by gve kernel driver and we just keep it here. Thanks!
>
> +#define GVE_DEVICE_OPTION_ERROR_FMT "%s option error:\n" \
> +"Expected: length=%d, feature_mask=%x.\n" \
> +"Actual: length=%d, feature_mask=%x."
> +
>
> Why such a wordy multi-line message, please use single line
This one is also from gve kernel driver.
Will update with single line message in the coming version.
Thanks!
