Hi Akhil, Thanks for your feedback. I will do the suggested changes in next version of the patch.
> -----Original Message----- > From: Akhil Goyal <[email protected]> > Sent: Tuesday, September 27, 2022 1:37 PM > To: Amit Prakash Shukla <[email protected]>; Fan Zhang > <[email protected]>; Ray Kinsella <[email protected]> > Cc: [email protected]; Jerin Jacob Kollanukkaran <[email protected]>; Amit > Prakash Shukla <[email protected]> > Subject: RE: [PATCH] cryptodev: add trace points > > > diff --git a/lib/cryptodev/rte_cryptodev_trace.h > > b/lib/cryptodev/rte_cryptodev_trace.h > > index a3f6048e7d..84991c5b0a 100644 > > --- a/lib/cryptodev/rte_cryptodev_trace.h > > +++ b/lib/cryptodev/rte_cryptodev_trace.h > > @@ -18,6 +18,7 @@ extern "C" { > > #include <rte_trace_point.h> > > > > #include "rte_cryptodev.h" > > +#include "cryptodev_pmd.h" > > We cannot include library internal header into external header. > We can either have a have a separate file for pmd specific APIs And hide it > from user or do not allow tracing for pmd APIs. > > > > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > > index 5aee87c6f7..a788185229 100644 > > --- a/lib/cryptodev/version.map > > +++ b/lib/cryptodev/version.map > > @@ -109,6 +109,63 @@ EXPERIMENTAL { > > #added in 22.07 > > rte_cryptodev_session_event_mdata_set; > > rte_crypto_asym_ke_strings; > > + > > + #added in 22.11 > > > > + __rte_cryptodev_trace_pmd_allocate; > > + __rte_cryptodev_trace_pmd_callback_process; > > + __rte_cryptodev_trace_pmd_create; > > + __rte_cryptodev_trace_pmd_create_dev_name; > > + __rte_cryptodev_trace_pmd_destroy; > > + __rte_cryptodev_trace_pmd_get_dev; > > + __rte_cryptodev_trace_pmd_get_named_dev; > > + __rte_cryptodev_trace_pmd_parse_input_args; > > + __rte_cryptodev_trace_pmd_probing_finish; > > + __rte_cryptodev_trace_pmd_release_device; > > These can only be internal or just remove these.
