The code changes only update the comment description of rte_crypto_ec_point. Can you update commit message to indicate the comments update on expected behaviour when x.data and y.data equal to NULL.
Acked-by: Kai Ji <kai...@intel.com> > -----Original Message----- > From: Arek Kusztal <arkadiuszx.kusz...@intel.com> > Sent: Thursday, August 18, 2022 8:41 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> > Subject: [PATCH 1/2] cryptodev: add option to use ec base point in ecpm > > Add option to use elliptic curve generator point instead of setting it > manually. > It corresponds to the public point generation in EC Diffie-Hellman key > exchange. > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > --- > lib/cryptodev/rte_crypto_asym.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lib/cryptodev/rte_crypto_asym.h > b/lib/cryptodev/rte_crypto_asym.h index 8ae43d5f3d..62987f860e 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -593,7 +593,11 @@ struct rte_crypto_ecdsa_op_param { > */ > struct rte_crypto_ecpm_op_param { > struct rte_crypto_ec_point p; > - /**< x and y coordinates of input point */ > + /**< > + * x and y coordinates of input point, > + * in case both x.data and y.data are set to NULL > + * selected ellitpic curve generator point is used > + */ > > struct rte_crypto_ec_point r; > /**< x and y coordinates of resultant point */ > -- > 2.13.6