On 10/6/22 10:26, Ankur Dwivedi wrote:
Hi Andrew,
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Thursday, October 6, 2022 12:40 PM
To: Ankur Dwivedi <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; Igor
Russkikh <[email protected]>; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; Jerin Jacob
Kollanukkaran <[email protected]>; Maciej Czekaj [C]
<[email protected]>; Shijith Thotton <[email protected]>;
Srisivasubramanian Srinivasan <[email protected]>; Harman Kalra
<[email protected]>; [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; Nithin
Kumar Dabilpuram <[email protected]>; Kiran Kumar Kokkilagadda
<[email protected]>; Sunil Kumar Kori <[email protected]>; Satha
Koteswara Rao Kottidi <[email protected]>; Liron Himi
<[email protected]>; [email protected]; Radha Chintakuntla
<[email protected]>; Veerasenareddy Burru <[email protected]>;
Sathesh B Edara <[email protected]>; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected]; Rasesh Mody
<[email protected]>; Shahed Shaikh <[email protected]>; Devendra
Singh Rawat <[email protected]>; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]; [email protected];
[email protected]
Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library
External Email
----------------------------------------------------------------------
On 9/29/22 13:29, Ankur Dwivedi wrote:
This series adds trace points for functions in the ethdev library.
The trace points are added in ethdev, flow, mtr and tm files.
v2:
- Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks
as fastpath trace functions.
- Moved some trace functions call to the end to capture return value and
data.
Looking at the patch series I still see many-many places where tracing happens
on entry point. Intentional?
Yes , because the return values are not there to be captured.
Isn't it the reason to move trace point to have return value
there and capture it?
- Removed rte_eth_trace_tx_queue_setup as it is not required.
rte_ethdev_trace_txq_setup() is already present in
rte_eth_tx_queue_setup().
- Removed trace in ethdev_driver.c
- Removed trace function check patch.
Ankur Dwivedi (4):
ethdev: add trace points
ethdev: add trace points for flow
ethdev: add trace points for mtr
ethdev: add trace points for tm
lib/ethdev/ethdev_private.c | 3 +
lib/ethdev/ethdev_trace_points.c | 699 ++++++++++
lib/ethdev/rte_ethdev.c | 148 +++
lib/ethdev/rte_ethdev_trace.h | 2062
++++++++++++++++++++++++++++++
lib/ethdev/rte_ethdev_trace_fp.h | 19 +
lib/ethdev/rte_flow.c | 54 +
lib/ethdev/rte_mtr.c | 27 +
lib/ethdev/rte_tm.c | 40 +
lib/ethdev/version.map | 232 ++++
9 files changed, 3284 insertions(+)
