On Thu, Oct 6, 2022 at 10:28 AM Harry van Haaren <[email protected]> wrote: > > This commit extends the timeout for service_may_be_active() > from 100ms to 1000ms. Local testing on a idle and loaded system > (compiling DPDK with all cores) always completes after 1 ms. > > The wait time for a service-lcore to finish is also extended > from 100ms to 1000ms. > > The same timeout waiting code was duplicated in two tests, and > is now refactored to a standalone function avoiding duplication. > > Reported-by: David Marchand <[email protected]> > Suggested-by: Mattias Ronnblom <[email protected]> > Signed-off-by: Harry van Haaren <[email protected]>
Just to be sure, do we want such a timeout in the test logic itself? Is it that you want to make sure that the synchronisation happens in a "reasonable" (subject to discussion ;-)) amount of time? Otherwise, the unit tests run in the CI are themselves subject to a 10s x mutiplier timeout (-t meson test option). And then I would rely on this overall timeout. -- David Marchand
