On Wed, Oct 05, 2022 at 10:10:10PM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 4:35 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > To ensure all users are aware of KNI's deprecated status at build time > > we can take the following actions: > > > > 1. disable the library by default. It can be re-enabled by setting > > disabled_libs to the empty string (or other string not including > > 'kni') > > > > 2. add support for a list of deprecated libs to the lib/meson.build file > > so the error message for KNI being disabled includes the fact that it > > is a deprecated library. > > > > 3. for the dependent NIC driver, drivers/net/kni, modify its disabled > > message to also reference the fact that KNI is disabled. > > Let's say I want to re-enable the net/kni driver. > How should I do this? > > Passing -Denable_drivers=net/kni results in only getting net/kni. > Passing -Denable_drivers=*/* gives the same result as passing none: > net/kni is disabled because relying on a deprecated lib. >
Well, the error message still says that the library part is missing and that is why is has been disabled. In terms of enabling the library itself, from the doc part of the patch: +.. note:: + + KNI is disabled by default in the DPDK build. + To re-enable the library, remove 'kni' from the "disable_libs" meson option when configuring a build. I can similarly add a note to the net/kni documentation to say that it will be disabled by default because KNI is, and to re-enable it just enable KNI lib as described there. Is something like that needed, you think? /Bruce
