Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Wednesday, October 12, 2022 1:13 PM > To: Chautru, Nicolas <nicolas.chau...@intel.com>; dev@dpdk.org; > maxime.coque...@redhat.com > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce > <bruce.richard...@intel.com>; hemant.agra...@nxp.com; > david.march...@redhat.com; step...@networkplumber.org; Vargas, > Hernan <hernan.var...@intel.com>; tho...@monjalon.net > Subject: RE: [EXT] [PATCH v12 06/16] baseband/acc: add info get function > for ACC200 > > > diff --git a/drivers/baseband/acc/acc200_pmd.h > > b/drivers/baseband/acc/acc200_pmd.h > > index acead1d17c..587b6f6d5b 100644 > > --- a/drivers/baseband/acc/acc200_pmd.h > > +++ b/drivers/baseband/acc/acc200_pmd.h > > @@ -8,6 +8,7 @@ > > #include "acc_common.h" > > #include "acc200_pf_enum.h" > > #include "acc200_vf_enum.h" > > +#include "rte_acc200_cfg.h" > > > You should really fix your build procedure. > There have been 4-5 versions of this patchset due to build failures. > Even this v12 is not built properly. > Including this file "rte_acc200_cfg.h" here is not required and is not > available > until this patch. > This was highlighted in v11 but is still not fixed in v12.
This was my intent but somehow I clearly didn't do that amend for that commit as intended. I should have triple checked. > I removed this line while merging this series as I don't want to work again > on > this series. > > Please take care of builds in future. Thanks and sorry for the churn. We have an issue in our CICD and the patch by patch build but I should have checked manually all meson build. > I have not merged the last patch for test-bbdev as it is not reviewed yet and > was introduced in v10 only. > You should not introduce such new patches so late in the cycle of review of a > patchset. > > With above build issue fixed, series applied to dpdk-next-crypto except the > last patch. > > @Maxime can you please review the last patch of the series also. > Thanks again.
