On Fri, 29 May 2015 09:15:09 -0400
Liang-Min Larry Wang <liang-min.wang at intel.com> wrote:

> +     drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t);
> +     drvinfo->testinfo_len = 0;


Providing a hook to access more functionality is good and compatiablity
with old API's is helpful.  Too bad ethtool is kind of a clunky old
inflexible, and easily broken with changes. But that is not your fault.

Duplicating eth_stats in ethtool is not helpful.
This is actively discouraged for Linux device drivers.

Reply via email to