On 10/10/2022 11:17 AM, Junfeng Guo wrote:
The following base code is based on Google Virtual Ethernet (gve)
driver v1.3.0 under MIT license.
- gve_adminq.c
- gve_adminq.h
- gve_desc.h
- gve_desc_dqo.h
- gve_register.h
- gve.h

The original code is in:
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/\
tree/v1.3.0/google/gve

Note that these code are not Intel files and they come from the kernel
community. The base code there has the statement of
SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the
required MIT license as an exception to DPDK.

Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com>
Signed-off-by: Haiyue Wang <haiyue.w...@intel.com>
Signed-off-by: Junfeng Guo <junfeng....@intel.com>

<...>

diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h
new file mode 100644
index 0000000000..1b0d59b639
--- /dev/null
+++ b/drivers/net/gve/base/gve.h
@@ -0,0 +1,58 @@
+/* SPDX-License-Identifier: MIT
+ * Google Virtual Ethernet (gve) driver
+ * Version: 1.3.0

There is a version macro in the code, is version information required in the file comment?

+ * Copyright (C) 2015-2022 Google, Inc.
+ * Copyright(C) 2022 Intel Corporation

I don't know if it is OK to add Intel copyright, as far as I know this requires big enough contribution to the code, if this is copy of existing code, may be only original copyright should exist.

cc'ed @Hemant and @Stephen for more comment.

Reply via email to