> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Friday, October 21, 2022 17:51
> To: Guo, Junfeng <[email protected]>; Zhang, Qi Z
> <[email protected]>; Wu, Jingjing <[email protected]>;
> [email protected]; Xing, Beilei <[email protected]>
> Cc: [email protected]; Li, Xiaoyun <[email protected]>;
> [email protected]; Richardson, Bruce
> <[email protected]>; [email protected];
> [email protected]; Xia, Chenbo <[email protected]>;
> Zhang, Helin <[email protected]>
> Subject: Re: [PATCH v7 6/8] net/gve: add support for dev info get and dev
> configure
> 
> On 10/21/2022 10:19 AM, Junfeng Guo wrote:
> 
> >
> > Add dev_ops dev_infos_get.
> > Complete dev_configure with RX offloads force enabling.
> >
> > Signed-off-by: Xiaoyun Li <[email protected]>
> > Signed-off-by: Junfeng Guo <[email protected]>
> 
> <...>
> 
> > --- a/doc/guides/nics/gve.rst
> > +++ b/doc/guides/nics/gve.rst
> > @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic
> functionality of packet
> >   reception and transmission.
> >   Supported features of the GVE PMD are:
> >
> > +- Receiver Side Scaling (RSS)
> 
> [copy/paste from previous version]
> 
> I am not sure if driver can claim this, I can see a RSS hash is provided
> but is it possible to update which hash function to use or update key or
> RETA table to configure which queue packets goes?
> 
> Right now what is RSS calculated on?
> 
> Perpaps RSS support can be documented as limited?
> 
> And not sure if this update belongs this patch, it should be to the one
> that has the datapath.

Looks that the RSS is enabled by default, and there is no RSS init API.
So I just added back the force-enabled RSS offloading code with the
corresponding commit message. So the feature list remains unchaged.
Thanks!

Reply via email to