I was about to merge this series, and after long thoughts, it deserves a bit more changes. I would like to work with you for a merge in 22.11-rc3.
13/10/2022 12:35, Juraj Linkeš: > All the necessary code needed to connect to a node in a topology with > a bit more, such as basic logging and some extra useful methods. There is also some developer tooling, and some documentation. [...] > There are configuration files with a README that help with setting up > the execution/development environment. I don't want to merge some doc which is not integrated in the doc/ directory. It should be in RST format in doc/guides/dts/ I can help with this conversion. > The code only connects to a node. You'll see logs emitted to console > saying where DTS connected. > > There's only a bit of documentation, as there's not much to document. > We'll add some real docs when there's enough functionality to document, > when the HelloWorld testcases is in (point 4 in our roadmap below). What > will be documented later is runtime dependencies and how to set up the DTS > control node environment. > [...] > .editorconfig | 2 +- > .gitignore | 9 +- Updating general Python guidelines in these files should be done separately to get broader agreement. > MAINTAINERS | 5 + You can update this file in the first patch. > devtools/python-checkpatch.sh | 39 ++ Let's postpone the integration of checkpatch. It should be integrated with the existing checkpatch. > devtools/python-format.sh | 54 +++ > devtools/python-lint.sh | 26 ++ Let's postpone the integration of these tools. We need to discuss what is specific to DTS or not. > doc/guides/contributing/coding_style.rst | 4 +- It is not specific to DTS. > dts/.devcontainer/devcontainer.json | 30 ++ > dts/Dockerfile | 39 ++ Not sure about Docker tied to some personal choices. > dts/README.md | 154 ++++++++ As said above, it should in RST format in doc/guides/dts/ > dts/conf.yaml | 6 + > dts/framework/__init__.py | 4 + > dts/framework/config/__init__.py | 100 +++++ > dts/framework/config/conf_yaml_schema.json | 65 ++++ > dts/framework/dts.py | 68 ++++ > dts/framework/exception.py | 57 +++ > dts/framework/logger.py | 114 ++++++ > dts/framework/remote_session/__init__.py | 15 + > .../remote_session/remote_session.py | 100 +++++ > dts/framework/remote_session/ssh_session.py | 185 +++++++++ > dts/framework/settings.py | 119 ++++++ > dts/framework/testbed_model/__init__.py | 8 + > dts/framework/testbed_model/node.py | 63 ++++ > dts/framework/utils.py | 31 ++ > dts/main.py | 24 ++ > dts/poetry.lock | 351 ++++++++++++++++++ A lot of dependencies look not useful in this first series for SSH connection. > dts/pyproject.toml | 55 +++ > 27 files changed, 1723 insertions(+), 4 deletions(-)