On 11/2/22 10:07, Li, WeiyuanX wrote:
-----Original Message-----
From: humin (Q) <[email protected]>
Sent: Tuesday, November 1, 2022 10:21 AM
To: Ivan Malov <[email protected]>; [email protected]
Cc: Li, WeiyuanX <[email protected]>; Chas Williams <[email protected]>;
Hari Kumar Vemula <[email protected]>; [email protected];
Andrew Rybchenko <[email protected]>
Subject: Re: [PATCH] net/bonding: set initial value of descriptor count
alignment
Acked-by: Min Hu (Connor) <[email protected]>
在 2022/10/31 21:17, Ivan Malov 写道:
The driver had once been broken by patch [1] looking to have a
non-zero "nb_max" value in a use case not involving adding any
back-end ports. That was addressed afterwards ([2]). But, as per
report [3], similar test cases exist which attempt to setup Rx queues
on a void bond before attaching any back-end ports. Rx queue setup, in
turn, involves device info get API invocation, and one of the checks
on received data causes an exception (division by zero). The
"nb_align" value is indeed zero at that time, but, as explained in
[2], such test cases are totally incorrect since a bond device must
have at least one back-end port plugged before any ethdev APIs can be
used.
Once again, to avoid any problems with fixing the test cases, this
patch adjusts the bond PMD itself to workaround the bug.
[1] commit 5be3b40fea60 ("net/bonding: fix values of descriptor
limits") [2] commit d03c0e83cc00 ("net/bonding: fix descriptor limit
reporting") [3] https://bugs.dpdk.org/show_bug.cgi?id=1118
Fixes: d03c0e83cc00 ("net/bonding: fix descriptor limit reporting")
Cc: [email protected]
Signed-off-by: Ivan Malov <[email protected]>
Reviewed-by: Andrew Rybchenko <[email protected]>
---
Tested-by: Weiyuan Li <[email protected]>
This patch needs to be applied additionally
https://patches.dpdk.org/project/dpdk/patch/[email protected]/
can be verified to pass
Applied to dpdk-next-net/main, thanks.
