>2015-10-23 16:36, Harish Patil: >> > >> >2015-09-11 17:42, Rasesh Mody: >> >> #define SHMEM_EEE_ADV_STATUS_MASK 0x00f00000 >> >> #define SHMEM_EEE_100M_ADV (1<<0) >> >> - #define SHMEM_EEE_1G_ADV (1<<1) >> >> + #define SHMEM_EEE_1G_ADV (1U<<1) >> >> #define SHMEM_EEE_10G_ADV (1<<2) >> > >> >Why other constants are not changed? >> I only addressed the build error which is against SHMEM_EEE_1G_ADV. >> Is that okay? > >I would say no but you have the ownership on this code. >Please think which code quality you are expecting.
[Harish] I checked out internally. This is a header file based on regspecs which would be difficult to change/test everywhere. So I would just have to do this point fix. > >> This message and any attached documents contain information from the >>sending company or its parent company(s), subsidiaries, divisions or >>branch offices that may be confidential. If you are not the intended >>recipient, you may not read, copy, distribute, or use this information. >>If you have received this transmission in error, please notify the >>sender immediately by reply e-mail and then delete this message. > >Please remove this footer, irrelevant on a mailing list. > ________________________________ This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
