On Thu, Dec 15, 2022 at 09:42:40AM +0000, Bruce Richardson wrote:
> On Thu, Dec 15, 2022 at 09:49:06AM +0800, lihuisong (C) wrote:
> >
> > 在 2022/12/14 2:27, Bruce Richardson 写道:
> > > For future standardization on the "uint" name for unsigned values rather
> > > than the existing "u64" one, we can for now:
> > > * rename all internal values to use uint rather than u64
> > > * add new function names to alias the existing u64 ones
> > >
> > > Suggested-by: Morten Brørup <m...@smartsharesystems.com>
> > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > > ---
> > > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++++++++++++++++++++++
> > > lib/telemetry/telemetry.c | 16 +++++++--------
> > > lib/telemetry/telemetry_data.c | 28 ++++++++++++++++++--------
> > > lib/telemetry/telemetry_data.h | 4 ++--
> > > lib/telemetry/version.map | 7 +++++++
> > > 5 files changed, 73 insertions(+), 18 deletions(-)
> > >
> > > diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
> > > index c2ad65effe..60877dae0a 100644
> > > --- a/lib/telemetry/rte_telemetry.h
> > > +++ b/lib/telemetry/rte_telemetry.h
> > > @@ -8,6 +8,8 @@
> > > #ifndef _RTE_TELEMETRY_H_
> > > #define _RTE_TELEMETRY_H_
> > > +#include <rte_compat.h>
> > > +
> > > #ifdef __cplusplus
> > > extern "C" {
> > > #endif
> > > @@ -121,6 +123,22 @@ int
> > > rte_tel_data_add_array_int(struct rte_tel_data *d, int x);
> > > /**
> > > + * Add an unsigned value to an array.
> > > + * The array must have been started by rte_tel_data_start_array() with
> > > + * RTE_TEL_UINT_VAL as the type parameter.
> > > + *
> > > + * @param d
> > > + * The data structure passed to the callback
> > > + * @param x
> > > + * The number to be returned in the array
> > > + * @return
> > > + * 0 on success, negative errno on error
> > > + */
> > > +__rte_experimental
> > > +int
> > > +rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x);
> > > +
> > > + /**
> > > * Add a uint64_t to an array.
> > > * The array must have been started by rte_tel_data_start_array() with
> > > * RTE_TEL_UINT_VAL as the type parameter.
> > > @@ -193,6 +211,24 @@ int
> > > rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int
> > > val);
> > > /**
> > > + * Add an unsigned value to a dictionary.
> > > + * The dict must have been started by rte_tel_data_start_dict().
> > > + *
> > > + * @param d
> > > + * The data structure passed to the callback
> > > + * @param name
> > > + * The name the value is to be stored under in the dict
> > > + * Must contain only alphanumeric characters or the symbols: '_' or '/'
> > > + * @param val
> > > + * The number to be stored in the dict
> > > + * @return
> > > + * 0 on success, negative errno on error, E2BIG on string truncation
> > > of name.
> > > + */
> > > +int __rte_experimental
> > __rte_experimental
> > int
> >
> > Right?
>
> Yes, that is right.
actually, it is consistent with how it is used in the rest of dpdk
and most compilers accept it before the return type. but actually it
applies to the symbol name.
this is not an argument to change the existing pattern, just pointing it
out the details.
