Hi David,
On 11/2/2015 11:53 PM, David Marchand wrote: > Hello, > > On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang <cunming.liang at intel.com> > wrote: > [snip] > >> diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h >> b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h >> index 45071b7..b8fd318 100644 >> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h >> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h >> @@ -77,6 +77,9 @@ struct rte_epoll_event { >> struct rte_epoll_data epdata; >> }; >> >> +#define MISC_VEC_ID (0) >> > "misc" is not really descriptive ... > > >> +#define RX_VEC_START (MISC_VEC_ID + 1) >> + >> > Please, prefix these macros properly. > Else, when looking at the driver code, this kind of macros seems to be > local to the driver. > > That makes sense, will fix it in v3. Thanks. /Steve