Hi Bruce, > -----Original Message----- > From: Richardson, Bruce <[email protected]> > Sent: Tuesday, January 17, 2023 10:04 PM > To: Jiang, Cheng1 <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; Hu, > Jiayu <[email protected]>; Ding, Xuan <[email protected]>; Ma, WenwuX > <[email protected]>; Wang, YuanX <[email protected]>; He, > Xingguang <[email protected]> > Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application > > On Tue, Jan 17, 2023 at 01:54:50PM +0000, Jiang, Cheng1 wrote: > > Hi Bruce, > > > > Thanks for your comments. > > Replies are inline. I'll fix them in the next version. > > > > Thanks, > > Cheng > > > > > -----Original Message----- > > > From: Richardson, Bruce <[email protected]> > > > Sent: Tuesday, January 17, 2023 9:00 PM > > > To: Jiang, Cheng1 <[email protected]> > > > Cc: [email protected]; [email protected]; [email protected]; > Hu, > > > Jiayu <[email protected]>; Ding, Xuan <[email protected]>; Ma, > > > WenwuX <[email protected]>; Wang, YuanX <[email protected]>; > > > He, Xingguang <[email protected]> > > > Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application > > > > > > On Tue, Jan 17, 2023 at 01:56:23AM +0000, Cheng Jiang wrote: > > <snip> > > > > > +#if !defined(RTE_EXEC_ENV_LINUX) > > > > + > > > > +int > > > > +main(int argc, char *argv[]) > > > > +{ > > > > + printf("OS not supported, skipping test\n"); > > > > + return 0; > > > > +} > > > > + > > > > > > What is linux-specific about this app? > > > > > > If we do need to limit the app to Linux-only I suggest using meson > > > to do so rather than putting #ifdefs in the code. > > > > Got it. Thanks! > > > Can you maybe clarify what is linux-specific about this app, or else perhaps > test > at least building on FreeBSD and windows. I'd rather not see stuff added just > for > Linux without some attempt to try on other OS's. > > /Bruce
In fact, there is no special reason to only support Linux. I will remove this restriction. Thanks! Cheng
