Hi Thomas, Please see inline.
Thanks, Anoob > Subject: [EXT] Re: [PATCH 1/5] net: add PDCP header > > External Email > > ---------------------------------------------------------------------- > 22/12/2022 10:25, Anoob Joseph: > > --- /dev/null > > +++ b/lib/net/rte_pdcp_hdr.h > > @@ -0,0 +1,93 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(C) 2022 Marvell. > > + */ > > + > > +#ifndef _RTE_PDCP_HDR_H_ > > +#define _RTE_PDCP_HDR_H_ > > No need of extra underscores before and after. [Anoob] I was following the example quoted in https://doc.dpdk.org/guides/contributing/coding_style.html. Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same. Isn't it better to have a uniform coding style?