On Fri, Jan 20, 2023 at 2:58 PM Su, Simei <[email protected]> wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand <[email protected]> > > Sent: Friday, January 20, 2023 3:34 PM > > To: Su, Simei <[email protected]> > > Cc: Xing, Beilei <[email protected]>; Zhang, Yuying > > <[email protected]>; [email protected]; Zhang, Qi Z > > <[email protected]>; Yang, Qiming <[email protected]>; > > [email protected]; Zhang, Helin <[email protected]> > > Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration > > > > On Mon, Jan 16, 2023 at 1:15 PM Su, Simei <[email protected]> wrote: > > > > > > Hi David, > > > > > > > -----Original Message----- > > > > From: David Marchand <[email protected]> > > > > Sent: Monday, January 16, 2023 7:19 PM > > > > To: Su, Simei <[email protected]> > > > > Cc: Xing, Beilei <[email protected]>; Zhang, Yuying > > > > <[email protected]>; [email protected]; Zhang, Qi Z > > > > <[email protected]>; Yang, Qiming <[email protected]>; > > > > [email protected]; Zhang, Helin <[email protected]> > > > > Subject: Re: [PATCH] net/i40e: rework maximum frame size > > > > configuration > > > > > > > > On Mon, Jan 16, 2023 at 11:54 AM Simei Su <[email protected]> wrote: > > > > > > > > > > This patch removes unnecessary link status check. > > > > > > > > > > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port > > > > > level") > > > > > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port > > > > > level") > > > > > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") > > > > > Cc: [email protected] > > > > > > > > > > Signed-off-by: Simei Su <[email protected]> > > > > > > > > Thanks for looking into the issue. > > > > > > > > This is rather close to what I had tried [1] along my original > > > > report, but it failed in the CI. > > > > Let's see how the validation of your patch goes. > > > > > > > > 1: > > > > > > https://patchwork.dpdk.org/project/dpdk/patch/20221212143715.29649-1 > > > > -d > > > > [email protected]/ > > > > > > > > > > OK. We will find one environment to see why the unit test failed. > > > > Any update? > > We can reproduce CI error, but "ifconfig interface up" needs to be done > firstly > to reproduce it otherwise this error won't exist. The specific reason hasn't > been > found currently. We will discuss it after Chinese New Year about how to > handle it > more reasonably.
We have regressions in stable releases. Please put priority when the team is back so that this topic is fixed in 23.03. Thanks. -- David Marchand
