For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the hardware port of the received packets.
This patch adds the tx_mhpsdp_hwport setting in Tx queue API, the hwport value reflects packets be sent to which hardware port. 0 is no port assigned and traffic will be routed between different hardware ports, if 0 is disabled then try to match on MHPSDP_HW_PORT with 0 will result in an error. Adds the new tx_mhpsdp_hwport field into the padding hole of rte_eth_txconf structure, the size of rte_eth_txconf keeps the same. Adds a suppress type for structure change in the ABI check file. This patch adds the testpmd command line: testpmd> port config (port_id) txq (queue_id) mhpsdp_hwport (value) For example, there're two hardware ports 0 and 1 connected to a single DPDK port (port id 0), and mhpsdp_hwport 1 stood for hardware port 0 and mhpsdp_hwport 2 stood for hardware port 1, used the below command to config tx mhpsdp_hwport for per Tx Queue: port config 0 txq 0 mhpsdp_hwport 1 port config 0 txq 1 mhpsdp_hwport 1 port config 0 txq 2 mhpsdp_hwport 2 port config 0 txq 3 mhpsdp_hwport 2 These commands config the TxQ index 0 and TxQ index 1 with mhpsdp_hwport 1, uses TxQ 0 or TxQ 1 send packets, these packets will be sent from the hardware port 0, and similar with hardware port 1 if sending packets with TxQ 2 or TxQ 3. Signed-off-by: Jiawei Wang <jiaw...@nvidia.com> --- app/test-pmd/cmdline.c | 84 +++++++++++++++++++++ devtools/libabigail.abignore | 5 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 13 ++++ lib/ethdev/rte_ethdev.h | 8 ++ 4 files changed, 110 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd4..db9ea8b18a 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -764,6 +764,10 @@ static void cmd_help_long_parsed(void *parsed_result, "port cleanup (port_id) txq (queue_id) (free_cnt)\n" " Cleanup txq mbufs for a specific Tx queue\n\n" + + "port config (port_id) txq (queue_id) mhpsdp_hwport (value)\n" + " Set the hwport value in mhpsdp " + "on a specific Tx queue\n\n" ); } @@ -12621,6 +12625,85 @@ static cmdline_parse_inst_t cmd_show_port_flow_transfer_proxy = { } }; +/* *** configure port txq mhpsdp_hwport value *** */ +struct cmd_config_tx_mhpsdp_hwport { + cmdline_fixed_string_t port; + cmdline_fixed_string_t config; + portid_t portid; + cmdline_fixed_string_t txq; + uint16_t qid; + cmdline_fixed_string_t mhpsdp_hwport; + uint16_t value; +}; + +static void +cmd_config_tx_mhpsdp_hwport_parsed(void *parsed_result, + __rte_unused struct cmdline *cl, + __rte_unused void *data) +{ + struct cmd_config_tx_mhpsdp_hwport *res = parsed_result; + struct rte_port *port; + + if (port_id_is_invalid(res->portid, ENABLED_WARN)) + return; + + if (res->portid == (portid_t)RTE_PORT_ALL) { + printf("Invalid port id\n"); + return; + } + + port = &ports[res->portid]; + + if (strcmp(res->txq, "txq")) { + printf("Unknown parameter\n"); + return; + } + if (tx_queue_id_is_invalid(res->qid)) + return; + + port->txq[res->qid].conf.tx_mhpsdp_hwport = res->value; + + cmd_reconfig_device_queue(res->portid, 0, 1); +} + +cmdline_parse_token_string_t cmd_config_tx_mhpsdp_hwport_port = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + port, "port"); +cmdline_parse_token_string_t cmd_config_tx_mhpsdp_hwport_config = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + config, "config"); +cmdline_parse_token_num_t cmd_config_tx_mhpsdp_hwport_portid = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + portid, RTE_UINT16); +cmdline_parse_token_string_t cmd_config_tx_mhpsdp_hwport_txq = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + txq, "txq"); +cmdline_parse_token_num_t cmd_config_tx_mhpsdp_hwport_qid = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + qid, RTE_UINT16); +cmdline_parse_token_string_t cmd_config_tx_mhpsdp_hwport_hwport = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + mhpsdp_hwport, "mhpsdp_hwport"); +cmdline_parse_token_num_t cmd_config_tx_mhpsdp_hwport_value = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_mhpsdp_hwport, + value, RTE_UINT16); + +static cmdline_parse_inst_t cmd_config_tx_mhpsdp_hwport = { + .f = cmd_config_tx_mhpsdp_hwport_parsed, + .data = (void *)0, + .help_str = "port config <port_id> txq <queue_id> mhpsdp_hwport <value>", + .tokens = { + (void *)&cmd_config_tx_mhpsdp_hwport_port, + (void *)&cmd_config_tx_mhpsdp_hwport_config, + (void *)&cmd_config_tx_mhpsdp_hwport_portid, + (void *)&cmd_config_tx_mhpsdp_hwport_txq, + (void *)&cmd_config_tx_mhpsdp_hwport_qid, + (void *)&cmd_config_tx_mhpsdp_hwport_hwport, + (void *)&cmd_config_tx_mhpsdp_hwport_value, + NULL, + }, +}; + /* ******************************************************************************** */ /* list of instructions */ @@ -12851,6 +12934,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { (cmdline_parse_inst_t *)&cmd_show_capability, (cmdline_parse_inst_t *)&cmd_set_flex_is_pattern, (cmdline_parse_inst_t *)&cmd_set_flex_spec_pattern, + (cmdline_parse_inst_t *)&cmd_config_tx_mhpsdp_hwport, NULL, }; diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 7a93de3ba1..cbbde4ef05 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -20,6 +20,11 @@ [suppress_file] soname_regexp = ^librte_.*mlx.*glue\. +; Ignore fields inserted in middle padding of rte_eth_txconf +[suppress_type] + name = rte_eth_txconf + has_data_member_inserted_between = {offset_after(tx_deferred_start), offset_of(offloads)} + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Experimental APIs exceptions ; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 7be7c55d63..a05fd0e7d0 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1605,6 +1605,19 @@ Enable or disable a per queue Tx offloading only on a specific Tx queue:: This command should be run when the port is stopped, or else it will fail. +config per queue Tx mhpsdp_hwport +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Configure a mhpsdp_hwport value per queue Tx offloading only on a specific Tx queue:: + + testpmd> port (port_id) txq (queue_id) mhpsdp_hwport (value) + +* ``mhpsdp_hwport``: reflects packet can be sent to which hardware port. + uses it on multiple hardware ports connect to + a single DPDK port (mhpsdp). + +This command should be run when the port is stopped, or else it will fail. + Config VXLAN Encap outer layers ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index c129ca1eaf..c1cef9e21d 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -1138,6 +1138,14 @@ struct rte_eth_txconf { less free descriptors than this value. */ uint8_t tx_deferred_start; /**< Do not start queue with rte_eth_dev_start(). */ + /** + * Hardware port index for mhpsdp. + * Value 0 is no port assigned and traffic could be routed between different + * hardware ports, if 0 is disabled then try to match on MHPSDP_HW_PORT with + * 0 will result in an error. + * Value starts from 1 means that the first hw port in the mhpsdp. + */ + uint8_t tx_mhpsdp_hwport; /** * Per-queue Tx offloads to be set using RTE_ETH_TX_OFFLOAD_* flags. * Only offloads set on tx_queue_offload_capa or tx_offload_capa -- 2.18.1