Hi Stephen BR Rongwei
> -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Thursday, February 2, 2023 00:56 > To: Rongwei Liu <[email protected]> > Cc: [email protected]; Matan Azrad <[email protected]>; Slava Ovsiienko > <[email protected]>; Ori Kam <[email protected]>; NBU-Contact- > Thomas Monjalon (EXTERNAL) <[email protected]>; Raslan Darawsheh > <[email protected]>; Aman Singh <[email protected]>; Yuying > Zhang <[email protected]>; Ferruh Yigit <[email protected]>; > Andrew Rybchenko <[email protected]> > Subject: Re: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field > > External email: Use caution opening links or attachments > > > On Wed, 1 Feb 2023 13:35:10 +0200 > Rongwei Liu <[email protected]> wrote: > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 7a8516829c..b8156ebca2 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -811,7 +811,8 @@ static const char *const modify_field_ids[] = { > > "udp_port_src", "udp_port_dst", > > "vxlan_vni", "geneve_vni", "gtp_teid", > > "tag", "mark", "meta", "pointer", "value", > > - "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", NULL > > + "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", > > + "ipv6_proto", NULL > > }; > > > > Would it be better to keep the table in alphabetical order here? There are two arrays related to modify_filed resources: one for enumeration definition and the other is string for testpmd cli. The sequence is strictly same. " keep the table in alphabetical " needs to change both the array and make sure the new comer is the same index. IMO, current approach is more friendly for new coming fields.
