On Mon, Nov 09, 2015 at 08:17:24AM +0000, Liu, Jijiang wrote: > > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Monday, November 09, 2015 12:17 PM > > To: Liu, Jijiang > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 8/8] examples/vhost:support TX offload in > > vhost sample > > > > On Wed, Nov 04, 2015 at 06:54:16PM +0800, Jijiang Liu wrote: > > > Change the vhost sample to support and test TX offload. > > > > > > Signed-off-by: Jijiang Liu <jijiang.liu at intel.com> > > > --- > > > examples/vhost/main.c | 128 > > > ++++++++++++++++++++++++++++++++++++++++++------- > > > 1 files changed, 111 insertions(+), 17 deletions(-) > > > > > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index > > > 9eac2d0..06e1e8b 100644 > > > --- a/examples/vhost/main.c > > > +++ b/examples/vhost/main.c > > > @@ -50,6 +50,10 @@ > > > #include <rte_string_fns.h> > > > #include <rte_malloc.h> > > > #include <rte_virtio_net.h> > > > +#include <rte_tcp.h> > > > +#include <rte_ip.h> > > > +#include <rte_udp.h> > > > +#include <rte_sctp.h> > > > > > > #include "main.h" > > > > > > @@ -140,6 +144,8 @@ > > > > > Actually, I'd like to see TSO/CSUM offloading is enabled by default: > > they are so common, and they are enabled in a lot places by default, say, > > kernel, qemu. There is no reason to make it "disable" here. > > > This is configuration only in the vhost sample, but TSO/CSUM is enabled by > default in lib leyer. > > If user want to use it in vhost sample, just change the configuration.
So, why do you want to disable it by default then? --yliu