Hi Tejasree, I think it will make more sense but I will let Akhil decide. -----Original Message----- From: Tejasree Kondoj <[email protected]> Sent: Tuesday, February 21, 2023 4:38 PM To: Nicolau, Radu <[email protected]>; Akhil Goyal <[email protected]> Cc: Anoob Joseph <[email protected]>; [email protected] Subject: RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16
Hi Radu, Shall I change AES-128-CTR iv_len field in cipher_algos struct of sa.c from 8 to 16 and revert below change? Thanks Tejasree > -----Original Message----- > From: Nicolau, Radu <[email protected]> > Sent: Wednesday, February 1, 2023 8:08 PM > To: Akhil Goyal <[email protected]> > Cc: Anoob Joseph <[email protected]>; [email protected]; Tejasree Kondoj > <[email protected]> > Subject: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV > length to > 16 > > External Email > > ---------------------------------------------------------------------- > Hi > > On 2/1/2023 2:16 PM, Akhil Goyal wrote: > > Hi Radu, > > > >> Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to > >> 16 > >> > >> Set AES-CTR IV length as 16 instead of taking from SA config option > >> since the application populates 16B IV in the datapath. AES-CTR > >> requires 16B IV constructed from nonce and counter. > >> > >> Signed-off-by: Tejasree Kondoj <[email protected]> > > Do you have a comment on this? > > No real objection, only that there is already an inconsistency in the > definitions of the aes-xxx-ctr entries, 128 bit IV is 8 bytes, 192 and > 256 are 16 bytes. Maybe it would be better to change the 128 bit > variant definition? In any case: > > Reviewed-by: Radu Nicolau <[email protected]>
