Re: [PATCH v2 12/16] test/bbdev: remove check for invalid opaque data

[Maxime Coquelin]

On 2/15/23 18:09, Hernan Vargas wrote:

Assert also if the opaque data is invalid.

New line needed before Fixes tag.

Fixes: 335c11fd276 ("app/bbdev: support HARQ validation")
Cc: sta...@dpdk.org

Signed-off-by: Hernan Vargas <hernan.var...@intel.com>
---
  app/test-bbdev/test_bbdev_perf.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index a19eda2de8..2ce1c7e7d3 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -79,7 +79,6 @@

#define SYNC_WAIT 0

  #define SYNC_START 1
-#define INVALID_OPAQUE -1

#define INVALID_QUEUE_ID -1

  /* Increment for next code block in external HARQ memory */
@@ -1999,10 +1998,9 @@ check_enc_status_and_ordering(struct rte_bbdev_enc_op 
*op,
                        "op_status (%d) != expected_status (%d)",
                        op->status, expected_status);

- if (op->opaque_data != (void *)(uintptr_t)INVALID_OPAQUE)

-               TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data,
-                               "Ordering error, expected %p, got %p",
-                               (void *)(uintptr_t)order_idx, op->opaque_data);
+       TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data,
+                       "Ordering error, expected %p, got %p",
+                       (void *)(uintptr_t)order_idx, op->opaque_data);

return TEST_SUCCESS;

  }

With typo fixed:
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Thanks,
Maxime