> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 22 February 2023 13.41 > > 22/02/2023 09:24, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Wednesday, 22 February 2023 09.01 > > > > > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > > Hi Thomas, > > > > > > > > Do you want me to squash the unit tests in the mempool lib patch > or do I > > > have to wait for the reviews from mempool maintainers > > > > > > Yes I think you can do the squash if Morten agrees. > > > > Yes, I agree. And if there are any more changes required before the > code is accepted by the maintainers, I will let Kamalakshitha make those > changes. > > > > > > How should the different acks/review tags be handled when squashing > two patches into one? > > > > The library patch has: > > > > Signed-off-by: Morten Brørup <m...@smartsharesystems.com> > > Acked-by: Konstantin Ananyev <konstantin.v.anan...@yandex.ru> > > Acked-by: Chengwen Feng <fengcheng...@huawei.com> > > Acked-by: Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com> > > > > And the test patch has: > > > > Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > Reviewed-by: Feifei Wang <feifei.wa...@arm.com> > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > > The cleanest is to remove Reviewed and Acked-by and let reviewer check > again. > About the sign-off, you keep both. > About the authorship, you must choose one.
Kamalakshitha, since I designed and fought for the mempool zero-copy API, which I consider the core part of the patch, I would prefer being designated as the author of the squashed patch. I'm no expert at git, but I think the "From" tag indicates the author. So the tags in the squashed patch should be: From: Morten Brørup <m...@smartsharesystems.com> Signed-off-by: Morten Brørup <m...@smartsharesystems.com> Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com>
