Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

[Levend Sayar]

Thanks Junfeng for acknowledging.

> On 23 Feb 2023, at 05:49, Guo, Junfeng <junfeng....@intel.com> wrote:
> 
> Thanks!
> 
>> -----Original Message-----
>> From: Levend Sayar <levendsa...@gmail.com>
>> Sent: Wednesday, February 22, 2023 00:44
>> To: Ferruh Yigit <ferruh.yi...@amd.com>
>> Cc: Guo, Junfeng <junfeng....@intel.com>; dev@dpdk.org
>> Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
>> 
>> Thanks Ferruh for the review.
>> 
>>> On 21 Feb 2023, at 18:58, Ferruh Yigit <ferruh.yi...@amd.com> wrote:
>>> 
>>> On 2/21/2023 2:18 PM, Levend Sayar wrote:
>>>> Google Virtual NIC rx/tx queue stats are added as extended stats.
>>>> 
>>>> Signed-off-by: Levend Sayar <levendsa...@gmail.com>
>>> 
>>> Reviewed-by: Ferruh Yigit <ferruh.yi...@amd.com>
>>> 
> 
> Acked-by: Junfeng Guo <junfeng....@intel.com>
> 
>>> <...>
>>> 
>>>> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)
>>>>    if (nb_alloc <= rxq->nb_avail) {
>>>>            diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq-
>>> sw_ring[idx], nb_alloc);
>>>>            if (diag < 0) {
>>>> +                  rxq->stats.no_mbufs_bulk++;
>>> 
>>> It is not common to record bulk alloc failures, but as 'no_mbufs'
>>> already recorded conventionally, I guess it is OK to keep this extra
>>> stat if it is helpful.
>>> 
>