Hi Thomas, Marvin has already tested the patches with a recent HEAD release of DPDK and are ready to test them as part of RC2. As you say the changes are localized to the Intel drivers and from our review they look like low risk of breaking anything else.
Thanks Waterman -----Original Message----- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Liu, Yong Sent: Tuesday, November 10, 2015 11:18 PM To: Mcnamara, John; Thomas Monjalon Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/7] ethdev: add additional ieee1588 support functions Hi Thomas& John, Some update from validation team. > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > Sent: Tuesday, November 10, 2015 10:12 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/7] ethdev: add additional ieee1588 > support functions > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Tuesday, November 10, 2015 11:58 AM > > To: Mcnamara, John > > Cc: Mrzyglod, DanielX T; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v5 1/7] ethdev: add additional > > ieee1588 support functions > > > > 2015-11-10 11:36, Mcnamara, John: > > > From: Thomas Monjalon > > > > I'll try to fix it now to be sure it will be one of the first > > > > series ready for the 2.3 cycle. > > > > > > These comments are minor and could be fixed now. > > > > After having a closer look in the drivers change, it seems to be > > restricted to the PTP functions of the Intel drivers. > > So you can ask to the Intel validation team if they are OK to add it > > in RC2. > > I think it would be a wrong idea because we need to stop moving the > ethdev > > and drivers code, and focus on other DPDK areas for the RC2. > > Hi Thomas, > > Ok. I'll ask the validation team to evaluate the effect of the patches. > > For our validation team's view, in this patch set implemented some APIs which used to support Precision Time Protocol. The sample based those APIs can work as real ptp client. We have verified it work fine with linux ptp server.
