2015-11-11 08:53, Liu, Jijiang: > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > On Wed, Nov 11, 2015 at 08:38:29AM +0000, Liu, Jijiang wrote: > > > According to virtio standard, those fileds should be set. > > > > If so, you'd better quote them here, or even to your patch commit. > > In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02, > > (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksum. > > (2) If the VIRTIO_NET_F_GUEST_CSUM feature was negotiated, the > VIRTIO_NET_HDR_F_NEEDS_- > CSUM bit in flags MAY be set: if so, the checksum on the packet is incomplete > and csum_start > and csum_offset indicate how to calculate it (see Packet Transmission point > 1). > > (3) If the VIRTIO_NET_F_GUEST_TSO4, TSO6 or UFO options were negotiated, then > gso_type > MAY be something other than VIRTIO_NET_HDR_GSO_NONE, and gso_size field > indicates > the desired MSS (see Packet Transmission point 2). > > The information can be included in the next version of patch set.
Yes quoting specifications or datasheets in commit messages is a really good idea. Thanks for improving the quality of the git history.
