On Wed, 11 Nov 2015 16:26:57 +0800 Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote: > > Add vhost TX offload(CSUM and TSO) support capabilities. > > Claiming first that we support something, and then actually implementing > in a later patch is wrong, as at this stage, we actually does not support > that, hence, the functionality is broken. > > --yliu Actually in this case it is okay to claim that driver "might" use offload cabability but never do it. But agree in general better to keep both together.