> -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: 10 March 2023 00:13 > To: Srikanth Yalavarthi <[email protected]> > Cc: [email protected]; Shivah Shankar Shankar Narayan Rao > <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Anup Prabhu <[email protected]>; Prince Takkar > <[email protected]>; Parijat Shukla <[email protected]> > Subject: [EXT] Re: [PATCH v4 04/12] app/mldev: add test case to validate > model ops > > External Email > > ---------------------------------------------------------------------- > 07/02/2023 16:49, Srikanth Yalavarthi: > > --- a/app/test-mldev/ml_options.c > > +++ b/app/test-mldev/ml_options.c > > @@ -4,6 +4,7 @@ > > > > #include <errno.h> > > #include <getopt.h> > > +#include <linux/limits.h> > > It breaks on non-Linux OS of course. > include <limits.h> is enough and more portable. > > I will fix while merging.
Currently ML is not supported on windows. Hence used <linux/limits.h>. Will be removed in version 5. > > In general, I think you have too many includes. > You could reduce them by using devtools/process-iwyu.py > Will do a cleanup on header includes in version 5.
