> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: 11 March 2023 13:42 > To: Tyler Retzlaff <roret...@linux.microsoft.com>; Stephen Hemminger > <step...@networkplumber.org> > Cc: dev@dpdk.org; David Marchand <david.march...@redhat.com>; > dev@dpdk.org; Srikanth Yalavarthi <syalavar...@marvell.com> > Subject: [EXT] Re: [PATCH] mldev: disable build on Windows > > External Email > > ---------------------------------------------------------------------- > 10/03/2023 23:54, Stephen Hemminger: > > On Fri, 10 Mar 2023 12:06:35 -0800 > > Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > > > > On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote: > > > > Caught by UNH lab, Windows compilation is broken because of symbol > > > > exports: > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_bfloat16_to_float32 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float16_to_float32 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_bfloat16 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_float16 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_int16 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_int8 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_uint16 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_float32_to_uint8 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_int16_to_float32 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_int8_to_float32 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_uint16_to_float32 > > > > rte_mldev_exports.def : error LNK2001: unresolved external symbol > > > > rte_ml_io_uint8_to_float32 > > > > > > > > Disable Windows build until this is fixed. > > > > > > is someone committed to do this? > > > > This is not hard to fix, please fix the Windows build rather than disabling. > > I think we may need to change how the NEON implementation is selected, > without using weak references. > > Feel free to submit a patch. >
I have submitted a patch to remove weak symbols and enable windows build. I could run windows build with MinGW-w64, but not a native build. http://patches.dpdk.org/project/dpdk/patch/20230311145056.16386-1-syalavar...@marvell.com/
