> -----Original Message-----
>  app/proc-info/main.c           | 210 ++++++++++++++++++++++++++++++++-

> +             {"edev-reset-xstats", 0, NULL, 0},
> +             {"show-edev-device-xstats", 0, NULL, 0},

We should support the eventdev id as argument to this command  and display 
stats for the given eventdev id.

> +     if (show_edev_xstats()) {
> +             const uint8_t ndevs = rte_event_dev_count();
> +
> +             if (ndevs == 0)
> +                     rte_panic("No event devs found. Do you need"
> +                       " to pass in a --vdev flag?\n");
> +
> +             if (ndevs > 1)
> +                     printf("Warning: More than one event dev, but using
> idx 0\n");

Why do we need to restrict to only eventdev 0? .I guess you should support 
displaying stats for any eventdev, not only the eventdev with index0.
 

> diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst

> +   --show-edev-port-xstats=port_num | --edev-dump-xstats | --edev-reset-
> xstats |
> +   --show-edev-device-xstats]
> 

For "--show-evdev-device-xstats" why don't we have eventdev id as argument ?
There can be more than one eventdev can exists right on the system?


> +**--show-edev-queue-xstats**
> +The show-edev-queue-xstats parameter enables stats for specified queue or
> all queues.

Here and in below text replace "stats" to "xstats", because  stats and xstats 
are different. 


Reply via email to