[PATCH v2 01/44] app/pdump: fix segment fault when parse args

[Chengwen Feng]

The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse --pdump args with 'only keys'
(e.g. 'port,queue=*').

Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng <fengcheng...@huawei.com>
---
 app/pdump/main.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index c6cf9d9c87..ff6940e2e5 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -170,6 +170,9 @@ parse_device_id(const char *key __rte_unused, const char 
*value,
 {
        struct pdump_tuples *pt = extra_args;
 
+       if (value == NULL)
+               return -EINVAL;
+
        pt->device_id = strdup(value);
        pt->dump_by_type = DEVICE_ID;
 
@@ -182,6 +185,9 @@ parse_queue(const char *key __rte_unused, const char 
*value, void *extra_args)
        unsigned long n;
        struct pdump_tuples *pt = extra_args;
 
+       if (value == NULL)
+               return -EINVAL;
+
        if (!strcmp(value, "*"))
                pt->queue = RTE_PDUMP_ALL_QUEUES;
        else {
@@ -197,6 +203,9 @@ parse_rxtxdev(const char *key, const char *value, void 
*extra_args)
 
        struct pdump_tuples *pt = extra_args;
 
+       if (value == NULL)
+               return -EINVAL;
+
        if (!strcmp(key, PDUMP_RX_DEV_ARG)) {
                strlcpy(pt->rx_dev, value, sizeof(pt->rx_dev));
                /* identify the tx stream type for pcap vdev */
@@ -220,6 +229,9 @@ parse_uint_value(const char *key, const char *value, void 
*extra_args)
        char *end;
        int ret = 0;
 
+       if (value == NULL)
+               return -EINVAL;
+
        errno = 0;
        v = extra_args;
        t = strtoul(value, &end, 10);
-- 
2.17.1