> -----Original Message----- > From: Kevin Traynor <[email protected]> > Sent: Thursday, March 23, 2023 10:51 PM > To: Zhang, Qi Z <[email protected]>; Su, Simei <[email protected]>; Xing, > Beilei <[email protected]>; Zhang, Yuying <[email protected]>; > [email protected]; Jiang, YuX <[email protected]> > Cc: [email protected]; Yang, Qiming <[email protected]>; [email protected]; > Luca Boccassi <[email protected]>; Mcnamara, John > <[email protected]> > Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration > > On 22/03/2023 16:50, Kevin Traynor wrote: > > On 27/02/2023 00:35, Zhang, Qi Z wrote: > >> > > > > Hi Simei/Qi/Yu > > > > Hi Yu, > > >> > >>> -----Original Message----- > >>> From: Su, Simei <[email protected]> > >>> Sent: Monday, February 20, 2023 4:00 PM > >>> To: Xing, Beilei <[email protected]>; Zhang, Yuying > >>> <[email protected]>; Zhang, Qi Z <[email protected]>; > >>> [email protected] > >>> Cc: [email protected]; Yang, Qiming <[email protected]>; Su, Simei > >>> <[email protected]>; [email protected] > >>> Subject: [PATCH v6] net/i40e: rework maximum frame size > >>> configuration > >>> > >>> One issue is reported by David Marchand that error occurs in OVS due > >>> to the fix patch in mentioned changes below. The detailed reproduce > >>> step and result are in > >>> https://patchwork.dpdk.org/project/dpdk/patch/ > >>> [email protected]/. > >>> > >>> This patch removes unnecessary link status check and directly sets > >>> mac config in dev_start. Also, it sets the parameter "wait to > >>> complete" true to wait for more time to make sure adminq command > execute completed. > >>> > > > >>> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port > >>> level") > >>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port > >>> level") > >>> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") > >>> Cc: [email protected] > > > > These patches caused an observable regression in multiple 20.11 and > > 21.11 LTS releases that was only caught a long time after releases. > > > > Is there anything being added to LTS validation for regression testing > > this issue, so we don't get caught again? > > > > This is the issue I was talking about earlier during the release meeting. Not > sure > if we were talking about the same patch. > > I was asking if there are some regression tests added/can be added to LTS > validation that will be run during each LTS validation cycle so we don't have > any > more regressions on it. > Hi Kevin, Thanks for your comments. Yes. We are adding additional case to cover more testing. For main branch, we have done the regression testing (including the additional case testing), they both work well. We hope the two related patches can be backported to LTS branch, and the second patch just reworks for previous bug's fix. Patch1: https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ a8ca8ed net/i40e: revert link status check on device start Pathc2: https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ 82fcf20 net/i40e: fix maximum frame size configuration
Best regards, Yu Jiang > thanks, > Kevin. > > > After reverting the original patch and 2 fixes, I'm a bit reluctant to > > take more fixes without some form of regression testing in place. > > > > thanks, > > Kevin. > > > >>> > >>> Reported-by: David Marchand <[email protected]> > >>> Signed-off-by: Simei Su <[email protected]> > >> > >> Acked-by: Qi Zhang <[email protected]> > >> > >> Applied to dpdk-next-net-intel. > >> > >> Thanks > >> Qi > >> > >
