On Tue, 11 Apr 2023 at 08:22, Morten Brørup <[email protected]> wrote: > > > From: Morten Brørup [mailto:[email protected]] > > Sent: Monday, 28 November 2022 13.08 > > > > > From: Luca Boccassi [mailto:[email protected]] > > > Sent: Monday, 28 November 2022 12.55 > > > > > > On Mon, 28 Nov 2022 at 11:35, Morten Brørup <[email protected]> > > > wrote: > > > > > > > > +CC Andrew Rybchenko as co-signer on the mempool patch in mainline. > > > > > > > > > From: [email protected] [mailto:[email protected]] > > > > > Sent: Monday, 28 November 2022 11.53 > > > > [...] > > > > > > > mempool: fix get objects from mempool with cache > > > > > > > > Reviewed stable release patch [1], comparing it to the accepted > > > mainline patch [2]. > > > > > > > > [1]: https://git.dpdk.org/dpdk- > > > stable/commit/?h=20.11&id=26cb4c81b552594292f7c744afb904f01700dfe8 > > > > [2]: > > > https://patchwork.dpdk.org/project/dpdk/patch/20221007104450.2567961-1- > > > [email protected]/ > > > > > > > > This is not correct: > > > > + __MEMPOOL_STAT_ADD(mp, get_success_bulk, 1); > > > > + __MEMPOOL_STAT_ADD(mp, get_success_objs, n); > > > > > > > > The old macro did more, so it should be: > > > > + __MEMPOOL_STAT_ADD(mp, get_success, n); > > > > > > > > This is only visible if built with RTE_LIBRTE_MEMPOOL_DEBUG. > > > > > > > > Besides that, it looks perfectly good to me. > > > > > > Can you test a patch and send it? > > > > Extremely busy these days... Not sure I can make it within the deadline. > > > > Alternatively, consider omitting the patch. It only fixes some performance > > issues for certain use cases. > > Now the omitted patch shows up as [Bug 1212], so I will try to provide a v2 > patch, continuing the work you already put into the v1 patch. > > [Bug 1212]: https://bugs.dpdk.org/show_bug.cgi?id=1212 > > However, I'm not good at git, so could you please provide a step-by-step > guide for contributing such a patch to the 20.11 stable branch? > > 1. git clone git://dpdk.org/(FIXME: Which URL?) > 2. (Edit and test the code.) > 3. git add lib/mempool/rte_mempool.h > 4. git commit (FIXME: Which additional parameters here?) -m "mempool: fix get > objects from mempool with cache" -m "Edit description in editor." --signoff > --edit (FIXME: And which special lines to add in the patch description?) > 5. git format-patch -1 -v 2 (FIXME: Which additional parameters here?) > 6. git send-email (FIXME: Which additional parameters here?) -to > [email protected] v2-000*.patch
Use the 20.11 branch from the https://git.dpdk.org/dpdk-stable/ repository. You can find instructions on how to send patches here: http://core.dpdk.org/contribute/
