> -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Friday, March 31, 2023 11:43 PM > To: [email protected]; [email protected]; Xia, Chenbo > <[email protected]>; [email protected]; [email protected]; > [email protected]; Liang, Cunming <[email protected]>; Xie, Yongji > <[email protected]>; [email protected]; [email protected]; > [email protected] > Cc: Maxime Coquelin <[email protected]>; [email protected] > Subject: [RFC 01/27] vhost: fix missing guest notif stat increment > > Guest notification counter was only incremented for split > ring, this patch adds it also for packed ring. > > Fixes: 1ea74efd7fa4 ("vhost: add statistics for guest notification") > Cc: [email protected] > > Signed-off-by: Maxime Coquelin <[email protected]> > --- > lib/vhost/vhost.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h > index 8fdab13c70..8554ab4002 100644 > --- a/lib/vhost/vhost.h > +++ b/lib/vhost/vhost.h > @@ -973,6 +973,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct > vhost_virtqueue *vq) > kick: > if (kick) { > eventfd_write(vq->callfd, (eventfd_t)1); > + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) > + vq->stats.guest_notifications++; > if (dev->notify_ops->guest_notified) > dev->notify_ops->guest_notified(dev->vid); > } > -- > 2.39.2
Reviewed-by: Chenbo Xia <[email protected]>
