Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Monday 24 April 2023 06:46 > To: Dooley, Brian <brian.doo...@intel.com>; Ji, Kai <kai...@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted feature > in AESNI_MB > > > Subject: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted > > feature in AESNI_MB AESNI_MB PMD does not support Digest Encrypted. > > This patch adds partial support for this feature. > > I do not get it, what is the point of adding partial support. > It should be added when it is supported. > Also whenever, you add, add in documentation as well. Apologies for this, This patch has a bit more work to do and should have been an RFC. Confident that it can be completed for the release. > > > > > > Signed-off-by: Brian Dooley <brian.doo...@intel.com> > > --- > > Some out-of-place tests are still failing. > > Only some in-place tests are passing. > > Working on adding support for this feature in v2. > > You cannot just send half cooked patches. > > > --- > > app/test/1.diff | 0 > > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 ++- > > 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 > > app/test/1.diff > > > > diff --git a/app/test/1.diff b/app/test/1.diff new file mode 100644 > > index 0000000000..e69de29bb2 > This file is accidently added.
Thanks, Brian
