On Tue, Apr 4, 2023 at 2:21 AM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > Refrain from using compiler __atomic_{add,and,nand,or,sub,xor}_fetch() > to ease future adoption of C11 standard atomics. > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > --- > devtools/checkpatches.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index a07bbc8..1b6841b 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -119,6 +119,14 @@ check_forbidden_additions() { # <patch> > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > "$1" || res=1 > > + # refrain from using compiler > __atomic_{add,and,nand,or,sub,xor}_fetch() > + awk -v FOLDERS="lib drivers app examples" \ > + -v EXPRESSIONS="__atomic_(add|and|nand|or|sub|xor)_fetch\\\(" > \ > + -v RET_ON_FAIL=1 \ > + -v MESSAGE='Using __atomic_op_fetch use __atomic_fetch_op > instead' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=1 > + > # forbid use of __reserved which is a reserved keyword in Windows > system headers > awk -v FOLDERS="lib drivers app examples" \ > -v EXPRESSIONS='\\<__reserved\\>' \ > -- > 1.8.3.1
I tweaked the warning message a bit, and applied. Thanks. -- David Marchand