On Sat, May 06, 2023 at 02:48:22PM +0800, Kaiwen Deng wrote:
> The i variable type is uint8_t which causes a dead loop,
> changing it to uint32_t will solve this issue.
> 
> Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Kaiwen Deng <kaiwenx.d...@intel.com>
> ---
>  drivers/net/ice/ice_dcf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
> index 1c3d22ae0f..2cf5de0380 100644
> --- a/drivers/net/ice/ice_dcf.c
> +++ b/drivers/net/ice/ice_dcf.c
> @@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
>  {
>       struct rte_eth_dev *dev = hw->eth_dev;
>       struct rte_eth_rss_conf *rss_conf;
> -     uint8_t i, j, nb_q;
> +     uint8_t j, nb_q;
> +     uint32_t i;

should be size_t

>       int ret;
>  
>       rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;

with or without suggested change, also isn't there a warning on gcc or
clang that can be enabled to detect this?

Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>

Reply via email to