RE: [PATCH v2] net/i40e: remove redundant judgment

[Zhang, Qi Z]

> -----Original Message-----
> From: Feifei Wang <feifei.wa...@arm.com>
> Sent: Tuesday, May 16, 2023 9:54 AM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Konstantin Ananyev
> <konstantin.v.anan...@yandex.ru>; Zhang, Yuying
> <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; David
> Christensen <d...@linux.vnet.ibm.com>; Ruifeng Wang
> <ruifeng.w...@arm.com>
> Cc: dev@dpdk.org; nd <n...@arm.com>; Honnappa Nagarahalli
> <honnappa.nagaraha...@arm.com>; nd <n...@arm.com>
> Subject: RE: [PATCH v2] net/i40e: remove redundant judgment
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zh...@intel.com>
> > Sent: Monday, May 15, 2023 9:59 AM
> > To: Zhang, Qi Z <qi.z.zh...@intel.com>; Feifei Wang
> > <feifei.wa...@arm.com>; Richardson, Bruce
> > <bruce.richard...@intel.com>; Konstantin Ananyev
> > <konstantin.v.anan...@yandex.ru>; Zhang, Yuying
> > <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; David
> > Christensen <d...@linux.vnet.ibm.com>; Ruifeng Wang
> > <ruifeng.w...@arm.com>
> > Cc: dev@dpdk.org; nd <n...@arm.com>; Honnappa Nagarahalli
> > <honnappa.nagaraha...@arm.com>
> > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhang, Qi Z <qi.z.zh...@intel.com>
> > > Sent: Thursday, April 27, 2023 3:38 PM
> > > To: Feifei Wang <feifei.wa...@arm.com>; Richardson, Bruce
> > > <bruce.richard...@intel.com>; Konstantin Ananyev
> > > <konstantin.v.anan...@yandex.ru>; Zhang, Yuying
> > > <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>;
> > > David Christensen <d...@linux.vnet.ibm.com>; Ruifeng Wang
> > > <ruifeng.w...@arm.com>
> > > Cc: dev@dpdk.org; n...@arm.com; Honnappa Nagarahalli
> > > <honnappa.nagaraha...@arm.com>
> > > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Feifei Wang <feifei.wa...@arm.com>
> > > > Sent: Tuesday, March 28, 2023 3:28 PM
> > > > To: Richardson, Bruce <bruce.richard...@intel.com>; Konstantin
> > > > Ananyev <konstantin.v.anan...@yandex.ru>; Zhang, Yuying
> > > > <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>;
> > > > David Christensen <d...@linux.vnet.ibm.com>; Ruifeng Wang
> > > > <ruifeng.w...@arm.com>
> > > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> <feifei.wa...@arm.com>;
> > > > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> > > > Subject: [PATCH v2] net/i40e: remove redundant judgment
> > > >
> > > > Merged variable updates under the same condition. It reduces branch.
> > > >
> > > > In ampere-altra, there is no performance improvement with this patch.
> > > > In x86 sse and avx2 path, there is also no performance improvement.
> > >
> > > Thanks for sharing the results. While the code implements some best
> > > practices, such as reducing branching and adding compiler hints,
> > > which should generally improve performance, it's not necessary to
> > > highlight that it didn't provide benefits on certain specific platforms.
> > >
> > > Would it be ok to remove the last two lines when merging the patch?
> >
> > Ping
> >
> Sorry for I did not reply this. I agree with this when  merging the patch.
> Thanks for the comments~.
> > >
> > > Otherwise
> > > Acked-by: Qi Zhang <qi.z.zh...@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi