> -----Original Message-----
> From: David Marchand [mailto:[email protected]]
> Sent: Thursday, January 5, 2023 4:34 PM
> To: wangyunjian <[email protected]>; Thomas Monjalon
> <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> Huangshaozhang <[email protected]>; [email protected];
> lianglipei <[email protected]>
> Subject: Re: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe
> 
> Hi Yunjian, Thomas,
> 
> On Mon, Dec 5, 2022 at 9:02 AM Yunjian Wang <[email protected]>
> wrote:
> >
> > In the device probing, there is no need to log the error message in
> > the case, that device has been already probed and return with -EEXIST.
> >
> > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> > Cc: [email protected]
> >
> > Signed-off-by: Lipei Liang <[email protected]>
> > Signed-off-by: Yunjian Wang <[email protected]>
> 
> It seems it is a partial fix and a duplicate work for:
> https://patchwork.dpdk.org/project/dpdk/patch/20190302024253.15594-3-tho
> [email protected]/

I agree with Thomas's patch. Can we consider merging this patch first?
Because this err log can easily mislead problem troubleshooting.

> 
> This patch is part of a series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=3612
> I see no activity on it, but there were some comments.
> 
> Thomas, do you intend to work on this series of yours?
> 
> 
> --
> David Marchand

Reply via email to