> -----Original Message----- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, January 5, 2023 4:34 PM > To: wangyunjian <wangyunj...@huawei.com>; Thomas Monjalon > <tho...@monjalon.net> > Cc: dev@dpdk.org; qi.z.zh...@intel.com; anatoly.bura...@intel.com; > Huangshaozhang <huangshaozh...@huawei.com>; sta...@dpdk.org; > lianglipei <liangli...@huawei.com> > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe > > Hi Yunjian, Thomas, > > On Mon, Dec 5, 2022 at 9:02 AM Yunjian Wang <wangyunj...@huawei.com> > wrote: > > > > In the device probing, there is no need to log the error message in > > the case, that device has been already probed and return with -EEXIST. > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Lipei Liang <liangli...@huawei.com> > > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com> > > It seems it is a partial fix and a duplicate work for: > https://patchwork.dpdk.org/project/dpdk/patch/20190302024253.15594-3-tho > m...@monjalon.net/
I agree with Thomas's patch. Can we consider merging this patch first? Because this err log can easily mislead problem troubleshooting. > > This patch is part of a series: > https://patchwork.dpdk.org/project/dpdk/list/?series=3612 > I see no activity on it, but there were some comments. > > Thomas, do you intend to work on this series of yours? > > > -- > David Marchand
