On Tue, May 30, 2023 at 3:02 PM Maxime Coquelin <maxime.coque...@redhat.com> wrote: > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentially block the PMD thread. > > > > The callback function can decide whether it's ok to handle the > > eventfd_write() now or have the newly introduced function, > > rte_vhost_notify_guest(), called at a later time. > > > > This can be used by 3rd party applications, like OVS, to avoid system > > calls being called as part of the PMD threads. > > > > Signed-off-by: Eelco Chaudron <echau...@redhat.com> > > --- > > lib/vhost/meson.build | 2 ++ > > lib/vhost/rte_vhost.h | 23 +++++++++++++++++- > > lib/vhost/socket.c | 63 > > ++++++++++++++++++++++++++++++++++++++++++++++--- > > lib/vhost/version.map | 9 +++++++ > > lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ > > lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++------------- > > 6 files changed, 171 insertions(+), 22 deletions(-) > > > > > The patch looks good to me, but that's the first time we use function > versioning in Vhost library, so I'd like another pair of eyes to be sure > I don't miss anything. > > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
There may be some enhancement to do in the symbol check (wrt to the warning http://mails.dpdk.org/archives/test-report/2023-May/394865.html) but otherwise the versioning part lgtm. -- David Marchand
