06/06/2023 15:38, Nipun Gupta: > > On 6/6/2023 6:30 PM, Thomas Monjalon wrote: > > > > 06/06/2023 12:02, Nipun Gupta: > >> +/* Forward declarations */ > >> +struct rte_cdx_device; > >> +struct rte_cdx_driver; > >> +struct rte_cdx_bus; > > > > You should be very careful about what you export. > > > >> + > >> +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" > > > > This define is not needed in the .h file. > > This is required and used by some of the out of tree CDX drivers which > are developed by the customers, so it is needed here.
In this case, it should be prefixed with RTE_ > > > >> + > >> +#define CDX_MAX_RESOURCE 4 > > > > This size looks required for rte_cdx_device, > > but as an exported constant, it should be prefixed with RTE_ > > Sure, will update. > > Thanks, > Nipun > > > > >> + > >> +/** Any CDX device identifier (vendor, device). */ > >> +#define RTE_CDX_ANY_ID (0xffff) > > > > > > >
