> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 24, 2015 6:55 AM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from > testpmd > > 2015-11-12 12:57, Chen Jing D: > > From: "Chen Jing D(Mark)" <jing.d.chen at intel.com> > > > > When the fm10k port is closed, both func tx_queue_clean() and > > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > > SW ring. The latter func won't do sanity check on those pointers > > and cause crash. > > > > The fix include 2 parts. > > 1. Remove Vector TX buffer release func since it can share the > > release functions with regular TX. > > 2. Add log to print out what actual Rx/Tx func is used. > > 2 parts mean 2 patches.
OK, I'll send 2. > > [...] > > + if (rx_using_sse) > > + PMD_INIT_LOG(ERR, "Use vector Rx func"); > > + else > > + PMD_INIT_LOG(ERR, "Use regular Rx func"); > > Why using en error log level? Because fm10k will decide best rx/tx func in running time, some users complain they can't find which rx/tx func they are using. the error level log will help them.