On 5/29/2023 12:21 PM, Fengnan Chang wrote:
when there is enough space for memseg, we should pormpt which config to modify, not just print numbers.Signed-off-by: Fengnan Chang <changfeng...@bytedance.com> --- lib/eal/linux/eal_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 0876974631..974db901b7 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end) break; } if (msl_idx == RTE_MAX_MEMSEG_LISTS) { - RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n", - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); + RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST " + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n"); return -1;
This is a problem with RTE_STR macro - replacing this with _RTE_STR will yield expected results (write out the RTE_MAX_MEMSEG_PER_TYPE as string). I'm not sure using _RTE_STR will be the correct solution though, because it's prefixed with an underscore (implying it should not be used directly), but I'm also not sure about writing out string literals like that explicitly.
-- Thanks, Anatoly
