If the prefix for the RSS hash was not chosen the ENOTSUP error should
be returned.
Before this patch success was returned for this case causing Rx queue
creation to fail.
Fixing return value to indicate failure.
Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash")
Cc: [email protected]
Signed-off-by: Artemii Morozov <[email protected]>
Reviewed-by: Andy Moreton <[email protected]>
Acked-by: Andrew Rybchenko <[email protected]>
---
v5: update commit message
v4: add Cc: [email protected] and transform rss to RSS
v3: update commit log as fix commit
v2: don't use capital letters in email
drivers/common/sfc_efx/base/efx_rx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/common/sfc_efx/base/efx_rx.c
b/drivers/common/sfc_efx/base/efx_rx.c
index 68f42f5cac..61726a9f0b 100644
--- a/drivers/common/sfc_efx/base/efx_rx.c
+++ b/drivers/common/sfc_efx/base/efx_rx.c
@@ -937,8 +937,10 @@ efx_rx_qcreate_internal(
rss_hash_field =
&erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH];
- if (rss_hash_field->erpfi_width_bits == 0)
+ if (rss_hash_field->erpfi_width_bits == 0) {
+ rc = ENOTSUP;
goto fail5;
+ }
}
enp->en_rx_qcount++;
--
2.34.1
