> -----Original Message-----
> From: Jerin Jacob <jerinjac...@gmail.com>
> Sent: Friday, July 7, 2023 6:17 PM
> To: Yan, Zhirun <zhirun....@intel.com>
> Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com;
> ndabilpu...@marvell.com; Fu, Qi <qi...@intel.com>
> Subject: Re: [PATCH v3] graph: fix graph model check in core binding
> 
> On Wed, Jul 5, 2023 at 7:38 AM Zhirun Yan <zhirun....@intel.com> wrote:
> >
> > Fix graph model check in core binding with graph. And
> > rte_graph_clone()
> 
> Two fixes, Lets have two patches. Also tell what is fixed and how it is fixed.
Ok, will do in next version.

> 
> 
> > need to use valid params rather than NULL pointer. Update release
> > notes for new mcore dispatch model.
> >
> > Fixes: ecb22a294980 ("graph: introduce graph bind unbind API")
> > Fixes: 67e2303cd823 ("test/graph: add functional tests for mcore
> > dispatch model")
> >
> > Signed-off-by: Zhirun Yan <zhirun....@intel.com>
> > ---
> >  app/test/test_graph.c                  | 15 ++++++++++++---
> >  doc/guides/rel_notes/release_23_07.rst | 11 +++++++++++
> >  lib/graph/graph.c                      |  2 +-
> >  3 files changed, 24 insertions(+), 4 deletions(-)
> >
> > diff --git a/app/test/test_graph.c b/app/test/test_graph.c index
> > 8609c0b3a4..8983363c8e 100644
> > --- a/app/test/test_graph.c
> > +++ b/app/test/test_graph.c
> > @@ -702,6 +702,7 @@
> test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
> >         unsigned int worker_lcore = RTE_MAX_LCORE;
> >         rte_node_t nid = RTE_NODE_ID_INVALID;
> >         char node_name[64] = "test_node00";
> > +       struct rte_graph_param graph_conf;
> 
> Initialize with zero or defaults, aka add =  { 0 }
Got it, thanks.

Reply via email to