On Tue, Jul 11, 2023 at 10:12:02AM +0100, Ferruh Yigit wrote:
> On 7/6/2023 3:42 AM, Stephen Hemminger wrote:
> > On Wed,  5 Jul 2023 19:32:48 -0700
> > Stephen Hemminger <[email protected]> wrote:
> > 
> >> The mailmap file is supposed to be in sorted order,
> >> but several entries are in the wrong place.
> >>
> >> Signed-off-by: Stephen Hemminger <[email protected]>
> >> ---
> >> v2 - use en_us.UTF-8 sort order
> >>
> >>  .mailmap | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/.mailmap b/.mailmap
> >> index d200f363394d..bfd3528cf734 100644
> >> --- a/.mailmap
> >> +++ b/.mailmap
> >> @@ -115,8 +115,8 @@ Anoob Joseph <[email protected]> 
> >> <[email protected]>
> >>  Antara Ganesh Kolar <[email protected]>
> >>  Anthony Fee <[email protected]>
> >>  Antonio Fischetti <[email protected]>
> >> -Anup Prabhu <[email protected]>
> >>  Anupam Kapoor <[email protected]>
> >> +Anup Prabhu <[email protected]>
> >>  Apeksha Gupta <[email protected]>
> >>  Archana Muniganti <[email protected]> 
> >> <[email protected]>
> >>  Archit Pandey <[email protected]>
> > 
> > Never mind, something is off if Anup shows up after Anupam
> >
> 
> This sorting logic already in the file:
>  Yanjie Xu <[email protected]>
>  Yan Xia <[email protected]>
> 
> and I don't know how to take following (may sort be ignoring the
> white-space between name and surname?):
>  Yi Li <[email protected]>
>  Yi Liu <[email protected]>
>  Yilong Lv <[email protected]>
>  Yi Lu <[email protected]>
> 
> 
> But to be able to sort whole file with 'sort' and no need to manually
> fix above quirks, I am OK with the change, hence:
> 
> Acked-by: Ferruh Yigit <[email protected]>

It's a good first step, but I tend to agree with Stephen that having Yan
appear after Yanjie indicates incorrect sorting.  Testing with "sort" on my
system, "sort -f" [or "sort --ignore-case"] seems to do the right thing.
The capital letter on the second names in the list may be throwing things
off.

/Bruce

Reply via email to