> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Thursday, August 17, 2023 2:27 PM > To: Naga Harish K, S V <[email protected]> > Cc: [email protected]; Jayatheerthan, Jay <[email protected]>; > Carrillo, Erik G <[email protected]>; Gujjar, Abhinandan S > <[email protected]>; McDaniel, Timothy > <[email protected]>; Pavan Nikhilesh > <[email protected]>; Shijith Thotton <[email protected]>; > Hemant Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Van Haaren, Harry > <[email protected]>; mattias.ronnblom > <[email protected]>; Liang Ma <[email protected]>; > Mccarthy, Peter <[email protected]> > Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API > > On Thu, Aug 17, 2023 at 11:33 AM Naga Harish K S V > <[email protected]> wrote: > > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > > creating Rx adapter instance. This API is similar to > > rte_event_eth_rx_adapter_create_ext() with an additional input > > argument for adapter configuration parameters of type "struct > > rte_event_eth_rx_adapter_params". > > > > Signed-off-by: Naga Harish K S V <[email protected]> > > > + */ > > +__rte_experimental > > +int __rte_cold > > Is there any specific reason to keep __rte_cold here? None of the other > libraries has this.
__rte_cold is a hint function in the cold path. It is used for code optimization purposes and many net PMDs are using this. > Rest looks good to me. > > For library changes, please keep all evendev maintainers in Cc. I have added > those now for this email. > > > > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, uint8_t > dev_id, > > + rte_event_eth_rx_adapter_conf_cb conf_cb, > > + void *conf_arg, > > + struct rte_event_eth_rx_adapter_params > > +*rxa_params);
