> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Monday, August 21, 2023 9:07 PM > To: Naga Harish K, S V <[email protected]> > Cc: [email protected]; Carrillo, Erik G <[email protected]>; Gujjar, > Abhinandan S <[email protected]>; McDaniel, Timothy > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; Van Haaren, Harry > <[email protected]>; mattias.ronnblom > <[email protected]>; [email protected]; Mccarthy, Peter > <[email protected]>; Jayatheerthan, Jay > <[email protected]> > Subject: Re: [PATCH v6] eventdev/eth_rx: add new adapter create API > > On Mon, Aug 21, 2023 at 8:59 PM Naga Harish K S V > <[email protected]> wrote: > > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > > creating Rx adapter instance. This API is similar to > > rte_event_eth_rx_adapter_create_ext() with an additional input > > argument for adapter configuration parameters of type "struct > > rte_event_eth_rx_adapter_params". > > > > Signed-off-by: Naga Harish K S V <[email protected]> > > --- > > v2: > > * Fix warning > > v3: > > * remove __rte_cold hint as per review comments > > v4: > > * address review comments > > v5: > > * Update release notes document > > v6: > > * incorporate review comments > > > +static int __rte_cold > > Missed again to remove _rte_cold. > Seriously, Please pay some attention when sending the patch(Same comment > given in last time). > __rte_cold is already removed for API definition and prototype. I thought having __rte_cold for this internal function is fine. It is removed in the latest patch, thanks.
> > > +rxa_config_params_validate(struct rte_event_eth_rx_adapter_params > *rxa_params, > > + struct rte_event_eth_rx_adapter_params > > +*temp_params)
